Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(223)

Issue 6308074: Preparation of hooking up the new preprocessor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Alok Priyadarshi
Modified:
13 years, 2 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Preparation of hooking up the new preprocessor. - Added custom Diagnostics class. Routed all info-log messages via this new class. - Added custom DirectiveHandler class. Moved directive-handling code to this class and routed the old path. - Deleted lexer_glue because it is not needed anymore. The new preprocessor is almost ready! - Killed a bunch of dead code related to PragmaTable. Committed: https://code.google.com/p/angleproject/source/detail?r=1150

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -633 lines) Patch
M src/build_angle.gyp View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/Compiler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/compiler/Diagnostics.h View 1 chunk +37 lines, -0 lines 0 comments Download
A src/compiler/Diagnostics.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
A src/compiler/DirectiveHandler.h View 1 chunk +46 lines, -0 lines 0 comments Download
A src/compiler/DirectiveHandler.cpp View 1 chunk +161 lines, -0 lines 0 comments Download
M src/compiler/ExtensionBehavior.h View 2 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/InitializeParseContext.h View 1 chunk +10 lines, -0 lines 0 comments Download
A src/compiler/InitializeParseContext.cpp View 1 chunk +96 lines, -0 lines 2 comments Download
M src/compiler/Intermediate.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ParseHelper.h View 7 chunks +15 lines, -23 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 12 chunks +62 lines, -118 lines 0 comments Download
A src/compiler/Pragma.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/compiler/ValidateLimitations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/debug.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/glslang.l View 4 chunks +9 lines, -130 lines 0 comments Download
M src/compiler/glslang.y View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 5 chunks +10 lines, -131 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/intermediate.h View 3 chunks +5 lines, -7 lines 0 comments Download
D src/compiler/preprocessor/lexer_glue.h View 1 chunk +0 lines, -15 lines 0 comments Download
D src/compiler/preprocessor/lexer_glue.cpp View 1 chunk +0 lines, -169 lines 0 comments Download
M src/compiler/preprocessor/scanner.c View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/preprocessor/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
Alok Priyadarshi
13 years, 2 months ago (2012-06-14 18:00:02 UTC) #1
kbr1
LGTM http://codereview.appspot.com/6308074/diff/1/src/compiler/InitializeParseContext.cpp File src/compiler/InitializeParseContext.cpp (right): http://codereview.appspot.com/6308074/diff/1/src/compiler/InitializeParseContext.cpp#newcode16 src/compiler/InitializeParseContext.cpp:16: assert(0 && "InitializeParseContextIndex(): Parse Context already initalised"); Typo: ...
13 years, 2 months ago (2012-06-15 06:28:48 UTC) #2
Alok Priyadarshi
13 years, 2 months ago (2012-06-15 15:44:00 UTC) #3
http://codereview.appspot.com/6308074/diff/1/src/compiler/InitializeParseCont...
File src/compiler/InitializeParseContext.cpp (right):

http://codereview.appspot.com/6308074/diff/1/src/compiler/InitializeParseCont...
src/compiler/InitializeParseContext.cpp:16: assert(0 &&
"InitializeParseContextIndex(): Parse Context already initalised");
On 2012/06/15 06:28:48, kbr1 wrote:
> Typo: initalised -> initialized, here and below.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b