Issue 6307083: Implemented line directive.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6307083: Implemented line directive. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Alok Priyadarshi

Modified:
11 years, 10 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implemented line directive. Committed: https://code.google.com/p/angleproject/source/detail?r=1149

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -23 lines)			Patch
M	src/compiler/preprocessor/new/Diagnostics.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	1	1 chunk	+56 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/Tokenizer.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Tokenizer.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Tokenizer.l	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/location_test.cpp	View	1	8 chunks	+125 lines, -22 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kbr1

11 years, 10 months ago (2012-06-15 05:41:45 UTC) #2

LGTM

Please make sure this works with the new line directive tests contributed by
David Sheets in https://cvs.khronos.org/bugzilla/show_bug.cgi?id=8881 (Khronos
login required).

Expand All Messages | Collapse All Messages