Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 6306083: code review 6306083: runtime: detect hash map collision problems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: detect hash map collision problems This can only happen if the hash function we're using is getting far more than it's fair share of collisions, but that has happened to us repeatedly as we've expanded the allowed use cases for hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695). Maybe this will help the next time we try something new.

Patch Set 1 #

Patch Set 2 : diff -r 5f4c5ee2f0ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e23033c49bcf https://code.google.com/p/go/ #

Patch Set 4 : diff -r e23033c49bcf https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/pkg/runtime/hashmap.c View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 9 months ago (2012-06-24 23:39:30 UTC) #1
rsc
Mike Burrows reviewed and okayed this CL.
12 years, 9 months ago (2012-06-24 23:40:34 UTC) #2
r
LGTM what are those funny marks on the end of the line?
12 years, 9 months ago (2012-06-24 23:42:08 UTC) #3
rsc
*** Submitted as f99b9475b914 *** runtime: detect hash map collision problems This can only happen ...
12 years, 9 months ago (2012-06-24 23:47:44 UTC) #4
rsc
12 years, 9 months ago (2012-06-24 23:47:48 UTC) #5
On Sun, Jun 24, 2012 at 7:42 PM,  <r@golang.org> wrote:
> what are those funny marks on the end of the line?

not sure, but i think it is the way people used to write comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b