Issue 6306080: code review 6306080: go.net/websocket: fix error check in Send

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306080: code review 6306080: go.net/websocket: fix error check in Send

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by ukai

Modified:
12 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

go.net/websocket: fix error check in Send Fixes issue 3727

Patch Set 1 #

Patch Set 2 : diff -r 3f9101a68d61 https://code.google.com/p/go.net/ #

Patch Set 3 : diff -r 3f9101a68d61 https://code.google.com/p/go.net/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	websocket/websocket.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ukai

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net/

12 years, 9 months ago (2012-06-14 01:36:20 UTC) #1

ukai

Could you submit it, please? (or do I have the permission to do it by ...

12 years, 9 months ago (2012-06-18 06:12:30 UTC) #4

adg

12 years, 9 months ago (2012-06-18 15:56:38 UTC) #5

*** Submitted as
http://code.google.com/p/go/source/detail?r=b999c58eaf75&repo=net ***

go.net/websocket: fix error check in Send

Fixes issue 3727

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6306080

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages