Best effort support for open-views.ee getting a string dataModel

[rbaxter85, 2012-06-13 02:26:23]

http://codereview.appspot.com/6306072/diff/1/features/src/main/javascript/fea...
File
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
(right):

http://codereview.appspot.com/6306072/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js:36:
* @param {Object}
We need to update the JSdoc here and in gadgets.views.openEmbeddedExperience. 
We should also update the JSUnit tests.

[rbaxter85, 2012-06-13 02:26:58]

On 2012/06/13 02:26:23, rbaxter85 wrote:
>
http://codereview.appspot.com/6306072/diff/1/features/src/main/javascript/fea...
> File
> features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
> (right):
> 
>
http://codereview.appspot.com/6306072/diff/1/features/src/main/javascript/fea...
>
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js:36:
> * @param {Object}
> We need to update the JSdoc here and in gadgets.views.openEmbeddedExperience. 
> We should also update the JSUnit tests.

Dan could you also add the dev list?

[ddumont1, 2012-06-13 12:48:56]

Updated jsdoc

[rbaxter85, 2012-06-13 13:42:45]

On 2012/06/13 12:48:56, ddumont1 wrote:
> Updated jsdoc

What about the unit tests?  Also add the dev list to the reviewers.

[ddumont1, 2012-06-13 18:14:31]

added jsunits

[ddumont1, 2012-06-13 18:37:34]

Questions for reviewers.

http://codereview.appspot.com/6306072/diff/9002/features/src/main/javascript/...
File
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
(right):

http://codereview.appspot.com/6306072/diff/9002/features/src/main/javascript/...
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js:65:
var match = new RegExp('^<(embed)>', 'i').exec(dataModel);
Is it right to expect the xml to start with an embed node here?  Is this email
only?   Is email the only place we support xml?

[rbaxter85, 2012-06-13 20:31:45]

LGTM

http://codereview.appspot.com/6306072/diff/9002/features/src/main/javascript/...
File
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
(right):

http://codereview.appspot.com/6306072/diff/9002/features/src/main/javascript/...
features/src/main/javascript/features/open-views.ee/open-views-ee-container.js:65:
var match = new RegExp('^<(embed)>', 'i').exec(dataModel);
On 2012/06/13 18:37:34, ddumont1 wrote:
> Is it right to expect the xml to start with an embed node here?  Is this email
> only?   Is email the only place we support xml?
No matter where the XML comes from the data model will always be wrapped in an
XML tag.

[henry.saputra, 2012-06-13 21:18:38]

+1