Issue 6306071: Update the DEPS file so that the RLZ project can build standalone. It

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306071: Update the DEPS file so that the RLZ project can build standalone. It (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Roger Tawa

Modified:
11 years, 10 months ago

Reviewers:
thakis

CC:
rlz-codereviews_googlegroups.com, stevet

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Update the DEPS file so that the RLZ project can build standalone. It currently builds only when part of a chrome build. BUG=None TEST=No user visible changes Committed: https://code.google.com/p/rlz/source/detail?r=131

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	DEPS	View		2 chunks	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thakis

lgtm http://codereview.appspot.com/6306071/diff/1/DEPS File DEPS (right): http://codereview.appspot.com/6306071/diff/1/DEPS#newcode47 DEPS:47: "http://src.chromium.org/svn/trunk/src/tools/win" + Var("chrev"), Alternatively, the script in this ...

11 years, 10 months ago (2012-06-12 15:34:37 UTC) #2

Roger Tawa

11 years, 10 months ago (2012-06-12 15:47:15 UTC) #3

Thanks Nico.

http://codereview.appspot.com/6306071/diff/1/DEPS
File DEPS (right):

http://codereview.appspot.com/6306071/diff/1/DEPS#newcode47
DEPS:47: "http://src.chromium.org/svn/trunk/src/tools/win" + Var("chrev"),
On 2012/06/12 15:34:37, thakis wrote:
> Alternatively, the script in this folder could be moved to build/ upstream.

OK, not sure what is implicated with that.  I will commit this for now to
unblock Steve, may look at it later.

Note that there is no need to bump the chrome DEPS revision for rlz with this
change.

Expand All Messages | Collapse All Messages