Issue 6306047: Program::link() and callees do not access mPixelHLSL, mVertexHLSL, mFragmentShader, mVertexShader, …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306047: Program::link() and callees do not access mPixelHLSL, mVertexHLSL, mFragmentShader, mVertexShader, … (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by apatrick1

Modified:
13 years, 2 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Program::link() and callees do not access mPixelHLSL, mVertexHLSL, mFragmentShader, mVertexShader, mAttributeBinding. mPixelHLSL and mVertexHLSL are deleted because they are only used during linking. Committed: https://code.google.com/p/angleproject/source/detail?r=1141

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2868 lines, -2843 lines)			Patch
	M	src/libGLESv2/Program.h	View	1	4 chunks	+18 lines, -8 lines	0 comments	Download
	M	src/libGLESv2/Program.cpp	View	1 2	1 chunk	+2850 lines, -2835 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dgkoch

13 years, 2 months ago (2012-06-06 19:54:42 UTC) #2

LGTM

https://codereview.appspot.com/6306047/diff/2001/src/libGLESv2/Program.cpp
File src/libGLESv2/Program.cpp (right):

https://codereview.appspot.com/6306047/diff/2001/src/libGLESv2/Program.cpp#ne...
src/libGLESv2/Program.cpp:188: return
mAttributeBindings.bindAttributeLocation(index, name);
'return' isn't really necessary here.

https://codereview.appspot.com/6306047/diff/2001/src/libGLESv2/Program.h
File src/libGLESv2/Program.h (right):

https://codereview.appspot.com/6306047/diff/2001/src/libGLESv2/Program.h#newc...
src/libGLESv2/Program.h:128: void link(const AttributeBindings
&attributeBindings, FragmentShader *fragmentShader, VertexShader *vertexShader);
This should probably be private, but as this is just a transitory patch it
probably doesn't matter.

Expand All Messages | Collapse All Messages