Issue 6305114: Refactor program info log out of ProgramBinary and in to Program.

Issue 6305114: Refactor program info log out of ProgramBinary and in to Program. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by apatrick1

Modified:
11 years, 10 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Refactor program info log out of ProgramBinary and in to Program. Tested by setting breakpoint in esLoadProgram with the broken program. Committed: https://code.google.com/p/angleproject/source/detail?r=1164

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : rebase #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -192 lines)			Patch
M	src/common/version.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Context.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Program.h	View	1 2	4 chunks	+22 lines, -0 lines	0 comments	Download
M	src/libGLESv2/Program.cpp	View	1 2	5 chunks	+127 lines, -25 lines	0 comments	Download
M	src/libGLESv2/ProgramBinary.h	View	1 2	5 chunks	+9 lines, -18 lines	0 comments	Download
M	src/libGLESv2/ProgramBinary.cpp	View	1 2	32 chunks	+37 lines, -140 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.cpp	View	1 2	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

apatrick1

Refactored as requested. PTAL. https://codereview.appspot.com/6305114/diff/2001/samples/gles2_book/Simple_VertexShader/Simple_VertexShader.c File samples/gles2_book/Simple_VertexShader/Simple_VertexShader.c (right): https://codereview.appspot.com/6305114/diff/2001/samples/gles2_book/Simple_VertexShader/Simple_VertexShader.c#newcode58 samples/gles2_book/Simple_VertexShader/Simple_VertexShader.c:58: "varying vec4 c;\n" Will not ...

11 years, 10 months ago (2012-06-19 23:16:30 UTC) #1

dgkoch

I think I like where this is going, but it seems incomplete. Missing the definition ...

11 years, 10 months ago (2012-06-20 02:33:32 UTC) #2

apatrick1

Oops. Not sure why I forgot to add those files. https://codereview.appspot.com/6305114/diff/2001/src/libGLESv2/ProgramBinary.h File src/libGLESv2/ProgramBinary.h (right): https://codereview.appspot.com/6305114/diff/2001/src/libGLESv2/ProgramBinary.h#newcode131 ...

11 years, 10 months ago (2012-06-21 19:01:38 UTC) #3

dgkoch

11 years, 10 months ago (2012-06-22 03:38:15 UTC) #4

LGTM

https://codereview.appspot.com/6305114/diff/7001/src/libGLESv2/Program.h
File src/libGLESv2/Program.h (right):

https://codereview.appspot.com/6305114/diff/7001/src/libGLESv2/Program.h#newc...
src/libGLESv2/Program.h:26: extern const char * const fakepath;
Not terribly keen on this, but I don't have a better suggestion at the moment.
Should put a "g_" prefix on it though.

Expand All Messages | Collapse All Messages