Issue 6305061: code review 6305061: cmd/gc: preserve side effects during inlining of functi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305061: code review 6305061: cmd/gc: preserve side effects during inlining of functi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:
ken3

CC:
ken2, golang-dev, lvd

Visibility:
Public.

cmd/gc: preserve side effects during inlining of function with _ argument Fixes issue 3593.

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -22 lines)			Patch
	M	src/cmd/gc/inl.c	View	1	3 chunks	+21 lines, -22 lines	0 comments	Download
	A	test/fixedbugs/bug441.go	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com, lvd), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-06-07 05:54:05 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=0ba8e27c7b87 *** cmd/gc: preserve side effects during inlining of function with _ ...

12 years, 9 months ago (2012-06-07 05:54:13 UTC) #2

lgtm