Issue 6305054: code review 6305054: net: fix cgoAddrInfoFlags() on FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305054: code review 6305054: net: fix cgoAddrInfoFlags() on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by minux1

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

net: fix cgoAddrInfoFlags() on FreeBSD CL 6250075 removed AI_MASK mask on all BSD variants, however FreeBSD's AI_MASK does not include AI_V4MAPPED and AI_ALL, and its libc is strict about the ai_flags. This will fix the FreeBSD builder.

Patch Set 1 #

Patch Set 2 : diff -r aa46d9ec8715 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2787cca7ac8f https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/cgo_bsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-06-06 12:15:50 UTC) #1

minux1

13 years, 1 month ago (2012-06-06 14:03:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ac649f1028db ***

net: fix cgoAddrInfoFlags() on FreeBSD
        CL 6250075 removed AI_MASK mask on all BSD variants,
        however FreeBSD's AI_MASK does not include AI_V4MAPPED
        and AI_ALL, and its libc is strict about the ai_flags.

        This will fix the FreeBSD builder.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6305054

Expand All Messages | Collapse All Messages