SHINDIG-1787 Calling navigateGadget again after the initial one destroys the content iframe and fail

CR for SHINDIG-1787 Calling navigateGadget again after the initial one destroys the content iframe and fails to navigate to the view

See https://issues.apache.org/jira/browse/SHINDIG-1787 for details

[rbaxter85, 2012-06-05 16:47:25]

Just a small suggestion.

http://codereview.appspot.com/6305045/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/container.site.gadget/gadget_site.js
(right):

http://codereview.appspot.com/6305045/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/container.site.gadget/gadget_site.js:295:
// Check if we are passed the loading gadget element
You could use the old code here, might look a little cleaner.
var el = this.loadingGadgetEl_ || this.el_;

[henry.saputra, 2012-06-05 16:55:40]

http://codereview.appspot.com/6305045/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/container.site.gadget/gadget_site.js
(right):

http://codereview.appspot.com/6305045/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/container.site.gadget/gadget_site.js:295:
// Check if we are passed the loading gadget element
On 2012/06/05 16:47:25, rbaxter85 wrote:
> You could use the old code here, might look a little cleaner.
> var el = this.loadingGadgetEl_ || this.el_;

Yeah agree. Will make the change

[henry.saputra, 2012-06-05 17:13:48]

Update based on Ryan's feedback

[rbaxter85, 2012-06-05 17:56:02]

On 2012/06/05 17:13:48, henry.saputra wrote:
> Update based on Ryan's feedback

LGTM.  I asked Dan to take a look as well.

[ddumont1, 2012-06-05 20:16:12]

On 2012/06/05 17:56:02, rbaxter85 wrote:
> On 2012/06/05 17:13:48, henry.saputra wrote:
> > Update based on Ryan's feedback
> 
> LGTM.  I asked Dan to take a look as well.

LGTM as well.

[henry.saputra, 2012-06-05 20:20:39]

Thanks All, Committed revision 1346571.

On 2012/06/05 20:16:12, ddumont1 wrote:
> On 2012/06/05 17:56:02, rbaxter85 wrote:
> > On 2012/06/05 17:13:48, henry.saputra wrote:
> > > Update based on Ryan's feedback
> > 
> > LGTM.  I asked Dan to take a look as well.
> 
> LGTM as well.