Issue 6304098: fixing compiler warnings in SkAAClip (Closed)
Descriptionfixing compiler warnings in SkAAClip
../src/core/SkAAClip.cpp: In member function ‘bool
SkAAClip::quickContains(int,
int, int, int) const’:
../src/core/SkAAClip.cpp:836:5: warning: ‘lastY’ may be used
uninitialized in
this function [-Wuninitialized]
../src/core/SkAAClip.cpp: In member function ‘virtual void
SkAAClipBlitter::blitV(int, int, int, SkAlpha)’:
../src/core/SkAAClip.cpp:1926:30: warning: ‘lastY’ may be used
uninitialized in
this function [-Wuninitialized]
../src/core/SkAAClip.cpp: In member function ‘virtual void
SkAAClipBlitter::blitMask(const SkMask&, const SkIRect&)’:
../src/core/SkAAClip.cpp:2144:51: warning: ‘localStopY’ may be used
uninitialized in this function [-Wuninitialized]
../src/core/SkAAClip.cpp: In member function ‘bool SkAAClip::op(const
SkAAClip&,
const SkAAClip&, SkRegion::Op)’:
../src/core/SkAAClip.cpp:159:9: warning:
‘iterB.SkAAClip::Iter::fStopYOff’ may
be used uninitialized in this function [-Wuninitialized]
../src/core/SkAAClip.cpp:1526:20: note:
‘iterB.SkAAClip::Iter::fStopYOff’ was
declared here
../src/core/SkAAClip.cpp:159:9: warning:
‘iterA.SkAAClip::Iter::fStopYOff’ may
be used uninitialized in this function [-Wuninitialized]
../src/core/SkAAClip.cpp:1525:20: note:
‘iterA.SkAAClip::Iter::fStopYOff’ was
declared here
WHile fixing this, I observed that parameters(lastYForRow,initialCount)
of
findRow and findX respectively are of pointer type. The callers of these
functions had to pass the parameter, even though they where not using it
later.Now,the parameters are initialized to null
Patch Set 1 #
Total comments: 8
Patch Set 2 : #
MessagesTotal messages: 6
|
||||||||||||||||||||||||||||
