Hooked up the new preprocessor behind a compile-time flag ANGLE_USE_NEW_PREPROCESSOR.

Hooked up the new preprocessor behind a compile-time flag ANGLE_USE_NEW_PREPROCESSOR.
Committed: https://code.google.com/p/angleproject/source/detail?r=1158

[Alok Priyadarshi, 2012-06-18 17:47:08]

http://codereview.appspot.com/6304095/diff/1/src/compiler/DirectiveHandler.cpp
File src/compiler/DirectiveHandler.cpp (right):

http://codereview.appspot.com/6304095/diff/1/src/compiler/DirectiveHandler.cp...
src/compiler/DirectiveHandler.cpp:30: : mExtensionBehavior(extBehavior),
just a rename in this file: mExtBehavior -> mExtensionBehavior

http://codereview.appspot.com/6304095/diff/1/src/compiler/DirectiveHandler.h
File src/compiler/DirectiveHandler.h (right):

http://codereview.appspot.com/6304095/diff/1/src/compiler/DirectiveHandler.h#...
src/compiler/DirectiveHandler.h:24: const TExtensionBehavior&
extensionBehavior() const { return mExtensionBehavior; }
just a rename in this file: mExtBehavior -> mExtensionBehavior

http://codereview.appspot.com/6304095/diff/1/src/compiler/ParseHelper.cpp
File src/compiler/ParseHelper.cpp (left):

http://codereview.appspot.com/6304095/diff/1/src/compiler/ParseHelper.cpp#old...
src/compiler/ParseHelper.cpp:15: extern "C" {
this block is moved to glslang.l

http://codereview.appspot.com/6304095/diff/1/src/compiler/ParseHelper.cpp#old...
src/compiler/ParseHelper.cpp:1516: if (!context->initPreprocessor())
moved to glslang_scan() in glslang.l

http://codereview.appspot.com/6304095/diff/1/src/compiler/ParseHelper.cpp#old...
src/compiler/ParseHelper.cpp:1527: context->destroyPreprocessor();
moved to glslang_finalize() in glslang.l

http://codereview.appspot.com/6304095/diff/1/src/compiler/glslang.l
File src/compiler/glslang.l (right):

http://codereview.appspot.com/6304095/diff/1/src/compiler/glslang.l#newcode506
src/compiler/glslang.l:506: //context->preprocessor.predefineMacro(iter->first,
1);
I will uncomment it before commiting. It depends on this patch under review:
http://codereview.appspot.com/6301084/

http://codereview.appspot.com/6304095/diff/1/src/compiler/preprocessor/new/Pr...
File src/compiler/preprocessor/new/Preprocessor.h (left):

http://codereview.appspot.com/6304095/diff/1/src/compiler/preprocessor/new/Pr...
src/compiler/preprocessor/new/Preprocessor.h:10: #include "DirectiveParser.h"
Including these files were leaking too many internal classes to the Preprocessor
client. Moved Preprocessor member variables into an opaque struct and moved
these includes into Preprocessor.cpp.

http://codereview.appspot.com/6304095/diff/1/src/compiler/preprocessor/new/Pr...
src/compiler/preprocessor/new/Preprocessor.h:42: MacroSet mMacroSet;
Moved these into an opaque struct PreprocessorImpl.

http://codereview.appspot.com/6304095/diff/1/tests/preprocessor_tests/input_t...
File tests/preprocessor_tests/input_test.cpp (right):

http://codereview.appspot.com/6304095/diff/1/tests/preprocessor_tests/input_t...
tests/preprocessor_tests/input_test.cpp:8: #include "Input.h"
A consequence of moving includes in Preprocessor.h to Preprocessor.cpp

[kbr1, 2012-06-19 17:27:17]

LGTM

Please make sure building with the standalone Visual Studio file works after
these changes.

[Alok Priyadarshi, 2012-06-19 17:33:15]

On 2012/06/19 17:27:17, kbr1 wrote:
> LGTM
> 
> Please make sure building with the standalone Visual Studio file works after
> these changes.

Will do. Thanks for reminding.

[dgkoch, 2012-06-19 17:42:16]

On 2012/06/19 17:33:15, Alok Priyadarshi wrote:
> On 2012/06/19 17:27:17, kbr1 wrote:
> > LGTM
> > 
> > Please make sure building with the standalone Visual Studio file works after
> > these changes.
> 
> Will do. Thanks for reminding.

Speaking of which .. it's actually broken right now :-0

[Alok Priyadarshi, 2012-06-19 17:43:09]

On 2012/06/19 17:42:16, dgkoch wrote:
> On 2012/06/19 17:33:15, Alok Priyadarshi wrote:
> > On 2012/06/19 17:27:17, kbr1 wrote:
> > > LGTM
> > > 
> > > Please make sure building with the standalone Visual Studio file works
after
> > > these changes.
> > 
> > Will do. Thanks for reminding.
> 
> Speaking of which .. it's actually broken right now :-0

Sorry. Will look into it right away.