Issue 6303074: Fix calling (and checking) the decal_ functions when the input is SkFractionalInt.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6303074: Fix calling (and checking) the decal_ functions when the input is SkFractionalInt. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by reed1

Modified:
12 years, 5 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix calling (and checking) the decal_ functions when the input is SkFractionalInt. The bug was to cast to SkFixed from SkFractionalInt, when what we needed to do was shift the fractional guy down to fixed. This bug was only caught on an android device w/o neon, since other configs have assembly for their matrixproc that didn't have this bug. Committed: https://code.google.com/p/skia/source/detail?r=4256

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -11 lines)			Patch
	M	src/core/SkBitmapProcState_matrix.h	View		2 chunks	+6 lines, -11 lines	0 comments	Download
	M	src/core/SkBitmapProcState_matrixProcs.cpp	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

EricB

12 years, 5 months ago (2012-06-13 15:34:54 UTC) #2

Verified that this produces the correct output on Xoom
(http://code.google.com/p/skia/issues/detail?id=642).

Expand All Messages | Collapse All Messages