Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6303065: Sets TabVoice Stem height to ##f (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by MikeSol
Modified:
7 years ago
Reviewers:
Keith, mike, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Sets TabVoice Stem height to ##f

Patch Set 1 #

Patch Set 2 : Mix of David and Keith's ideas. #

Total comments: 3

Patch Set 3 : Incorporates Keith's suggestions #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M lily/grob.cc View 1 chunk +4 lines, -1 line 2 comments Download
M lily/stem.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 21
MikeSol
Another way of going about this would be changing the Stem::height function so that it ...
7 years, 3 months ago (2012-06-10 18:22:50 UTC) #1
dak
On 2012/06/10 18:22:50, MikeSol wrote: > Another way of going about this would be changing ...
7 years, 3 months ago (2012-06-10 18:32:58 UTC) #2
Keith
http://codereview.appspot.com/6303065/diff/4001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/6303065/diff/4001/lily/stem.cc#newcode703 lily/stem.cc:703: if (calc_beam && !unsmob_stencil (me->get_property ("stencil"))) beam-stem-stemlet.ly shows that ...
7 years, 3 months ago (2012-06-11 03:44:32 UTC) #3
MikeSol
On 2012/06/11 03:44:32, Keith wrote: > http://codereview.appspot.com/6303065/diff/4001/lily/stem.cc > File lily/stem.cc (right): > > http://codereview.appspot.com/6303065/diff/4001/lily/stem.cc#newcode703 > ...
7 years, 3 months ago (2012-06-11 05:34:23 UTC) #4
dak
On 2012/06/11 05:34:23, MikeSol wrote: > This shows a case where stem height cannot be ...
7 years, 3 months ago (2012-06-11 07:10:48 UTC) #5
MikeSol
On 2012/06/11 07:10:48, dak wrote: > On 2012/06/11 05:34:23, MikeSol wrote: > > > This ...
7 years, 3 months ago (2012-06-11 07:24:33 UTC) #6
dak
On 2012/06/11 07:24:33, MikeSol wrote: > On 2012/06/11 07:10:48, dak wrote: > > > Personally, ...
7 years, 3 months ago (2012-06-11 07:48:34 UTC) #7
MikeSol
On 2012/06/11 07:48:34, dak wrote: > On 2012/06/11 07:24:33, MikeSol wrote: > > On 2012/06/11 ...
7 years, 3 months ago (2012-06-11 11:46:31 UTC) #8
Keith
LGTM if you re-read the comment before you push. http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc#newcode707 lily/stem.cc:707: ...
7 years, 3 months ago (2012-06-11 16:33:27 UTC) #9
dak
http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; I don't understand this. The only ...
7 years, 3 months ago (2012-06-12 12:32:37 UTC) #10
MikeSol
On 2012/06/12 12:32:37, dak wrote: > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc > File lily/grob.cc (right): > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 > ...
7 years, 3 months ago (2012-06-12 12:39:23 UTC) #11
dak
http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; On 2012/06/12 12:32:37, dak wrote: > ...
7 years, 3 months ago (2012-06-12 12:49:45 UTC) #12
MikeSol
On 2012/06/12 12:49:45, dak wrote: > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc > File lily/grob.cc (right): > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 > ...
7 years, 3 months ago (2012-06-12 12:54:40 UTC) #13
dak
On 2012/06/12 12:54:40, MikeSol wrote: > On 2012/06/12 12:49:45, dak wrote: > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc > ...
7 years, 3 months ago (2012-06-12 13:22:10 UTC) #14
MikeSol
On 2012/06/12 13:22:10, dak wrote: > On 2012/06/12 12:54:40, MikeSol wrote: > > On 2012/06/12 ...
7 years, 3 months ago (2012-06-12 13:27:23 UTC) #15
dak
Here is a code example from beam.cc: Interval weights (1 - multiplier, multiplier); if (feather_dir ...
7 years, 3 months ago (2012-06-12 13:43:09 UTC) #16
MikeSol
On 2012/06/12 13:43:09, dak wrote: > Here is a code example from beam.cc: > > ...
7 years, 3 months ago (2012-06-12 13:47:34 UTC) #17
dak
On 2012/06/12 13:47:34, MikeSol wrote: > On 2012/06/12 13:43:09, dak wrote: > > > If ...
7 years, 3 months ago (2012-06-12 14:09:35 UTC) #18
dak
On 2012/06/12 13:22:10, dak wrote: > On 2012/06/12 12:54:40, MikeSol wrote: > > On 2012/06/12 ...
7 years, 3 months ago (2012-06-15 07:33:31 UTC) #19
mike_apollinemike.com
On 15 juin 2012, at 09:33, dak@gnu.org wrote: > On 2012/06/12 13:22:10, dak wrote: >> ...
7 years, 3 months ago (2012-06-15 16:36:45 UTC) #20
Keith
7 years, 2 months ago (2012-07-14 07:52:16 UTC) #21
http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc
File lily/stem.cc (right):

http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc#newcode710
lily/stem.cc:710: if (calc_beam && !beam && !unsmob_stencil (me->get_property
("stencil")))
On 2012/06/11 16:33:27, Keith wrote:
> If you have time to test the output, consider removing the test for
calc_beam,

Bad suggestion, apparently, given that it disconnects the stems form merged
triangle note-heads.  I'll put back the test for calc_beam after I get through
regression testing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b