Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3314)

Issue 6303045: fix warnings on Mac in src/opts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by caryclark1
Modified:
12 years, 5 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

fix warnings on Mac in src/opts Fix these class of warnings: - unused functions - unused locals - sign mismatch - missing function prototypes - missing newline at end of file - 64 to 32 bit truncation The changes prefer to link in dead code in the debug build with 'if (false)' than to comment it out, but trivial cases are commented out or sometimes deleted if it appears to be a copy/paste error. Committed: https://code.google.com/p/skia/source/detail?r=4184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/opts/SkBlitRect_opts_SSE2.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
caryclark1
12 years, 5 months ago (2012-06-05 19:20:18 UTC) #1
TomH
12 years, 5 months ago (2012-06-05 19:22:05 UTC) #2
Eh, I don't like it, but I understand why you want to do this, and I hadn't
planned to revisit this soon.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b