Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 6303044: Support Mac-Android Cross-Compilation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by EricB
Modified:
12 years, 6 months ago
Reviewers:
epoger, DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Support Mac-Android Cross-Compilation - Rename Android sampleApp target to SampleAppAndroid to avoid name collision - Detect skia_os on Darwin to differentiate between xcode and make builds Committed: https://code.google.com/p/skia/source/detail?r=4168

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M Makefile View 1 1 chunk +8 lines, -5 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
EricB
12 years, 6 months ago (2012-06-05 15:13:31 UTC) #1
DerekS
lgtm
12 years, 6 months ago (2012-06-05 15:21:00 UTC) #2
epoger
http://codereview.appspot.com/6303044/diff/1/Makefile File Makefile (right): http://codereview.appspot.com/6303044/diff/1/Makefile#newcode92 Makefile:92: ifneq (,$(findstring skia_os=android, $(GYP_DEFINES))) As Derek mentioned, you could ...
12 years, 6 months ago (2012-06-05 16:06:59 UTC) #3
EricB
Modified accordingly. On 2012/06/05 16:06:59, epoger wrote: > http://codereview.appspot.com/6303044/diff/1/Makefile > File Makefile (right): > > ...
12 years, 6 months ago (2012-06-05 17:33:25 UTC) #4
epoger
12 years, 6 months ago (2012-06-05 17:47:32 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b