Support Mac-Android Cross-Compilation

Support Mac-Android Cross-Compilation

- Rename Android sampleApp target to SampleAppAndroid to avoid name collision
- Detect skia_os on Darwin to differentiate between xcode and make builds
Committed: https://code.google.com/p/skia/source/detail?r=4168

[DerekS, 2012-06-05 15:21:00]

lgtm

[epoger, 2012-06-05 16:06:59]

http://codereview.appspot.com/6303044/diff/1/Makefile
File Makefile (right):

http://codereview.appspot.com/6303044/diff/1/Makefile#newcode92
Makefile:92: ifneq (,$(findstring skia_os=android, $(GYP_DEFINES)))
As Derek mentioned, you could redo the logic like so to avoid the nested "if". 
I think it would be cleaner... and as a bonus, we would get an error for the
case where we had some unexpected $(uname).

ifneq (,$(findstring skia_os=android, $(GYP_DEFINES)))
        $(MAKE) -C out $@ BUILDTYPE=$(BUILDTYPE)
else ifneq (,$(findstring Linux, $(uname)))
        $(MAKE) -C out $@ BUILDTYPE=$(BUILDTYPE)
else ifneq (,$(findstring Darwin, $(uname)))
        blahblahblah
else
        echo "unknown platform $(uname)"
        exit 1
endif

[EricB, 2012-06-05 17:33:25]

Modified accordingly.

On 2012/06/05 16:06:59, epoger wrote:
> http://codereview.appspot.com/6303044/diff/1/Makefile
> File Makefile (right):
> 
> http://codereview.appspot.com/6303044/diff/1/Makefile#newcode92
> Makefile:92: ifneq (,$(findstring skia_os=android, $(GYP_DEFINES)))
> As Derek mentioned, you could redo the logic like so to avoid the nested "if".

> I think it would be cleaner... and as a bonus, we would get an error for the
> case where we had some unexpected $(uname).
> 
> ifneq (,$(findstring skia_os=android, $(GYP_DEFINES)))
>         $(MAKE) -C out $@ BUILDTYPE=$(BUILDTYPE)
> else ifneq (,$(findstring Linux, $(uname)))
>         $(MAKE) -C out $@ BUILDTYPE=$(BUILDTYPE)
> else ifneq (,$(findstring Darwin, $(uname)))
>         blahblahblah
> else
>         echo "unknown platform $(uname)"
>         exit 1
> endif

[epoger, 2012-06-05 17:47:32]

LGTM