Issue 6302063: code review 6302063: misc/emacs: Fix the automatic gofmt when creating a new...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6302063: code review 6302063: misc/emacs: Fix the automatic gofmt when creating a new... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by jme

Modified:
12 years, 9 months ago

Reviewers:

CC:
Sameer Ajmani, golang-dev

Visibility:
Public.

Description

misc/emacs: Fix the automatic gofmt when creating a new file. Patching the buffer with the output from gofmt -d only works if the file already exists. If it doesn't, replace the content with the output of gofmt.

Patch Set 1 #

Patch Set 2 : diff -r d34766b79c5e https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r d34766b79c5e https://code.google.com/p/go/ #

Patch Set 4 : diff -r d34766b79c5e https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -24 lines)			Patch
	M	misc/emacs/go-mode.el	View	1 2	1 chunk	+40 lines, -24 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sameer Ajmani

http://codereview.appspot.com/6302063/diff/1001/misc/emacs/go-mode.el File misc/emacs/go-mode.el (right): http://codereview.appspot.com/6302063/diff/1001/misc/emacs/go-mode.el#newcode786 misc/emacs/go-mode.el:786: (ftion (if newfile 'gofmt-replace-buffer obscure namee "ftion" -- perhaps ...

12 years, 9 months ago (2012-06-11 16:19:48 UTC) #1

jme

Hello sameer@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2012-06-11 16:25:40 UTC) #2

jme

12 years, 9 months ago (2012-06-11 16:25:56 UTC) #3

Sameer Ajmani

LGTM On 2012/06/11 16:25:56, jme wrote: > http://codereview.appspot.com/6302063/diff/1001/misc/emacs/go-mode.el > File misc/emacs/go-mode.el (right): > > http://codereview.appspot.com/6302063/diff/1001/misc/emacs/go-mode.el#newcode786 ...

12 years, 9 months ago (2012-06-11 16:27:30 UTC) #4

Sameer Ajmani

12 years, 9 months ago (2012-06-11 17:15:35 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=5b4920fe3605 ***

misc/emacs: Fix the automatic gofmt when creating a new file.

Patching the buffer with the output from gofmt -d only works if
the file already exists. If it doesn't, replace the content with
the output of gofmt.

R=sameer
CC=golang-dev
http://codereview.appspot.com/6302063

Committer: Sameer Ajmani <sameer@golang.org>

Expand All Messages | Collapse All Messages