code review 6301076: syscall: fix windows copyFindData

syscall: fix windows copyFindData

[rsc, 2012-06-13 19:22:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-06-13 20:27:20]

LGTM

On Wed, Jun 13, 2012 at 12:22 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: fix windows copyFindData
>
> Please review this at
http://codereview.appspot.com/**6301076/<http://codereview.appspot.com/6301076/>
>
> Affected files:
>  M src/pkg/syscall/ztypes_**windows.go
>
>
> Index: src/pkg/syscall/ztypes_**windows.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/ztypes_**windows.go
> +++ b/src/pkg/syscall/ztypes_**windows.go
> @@ -376,11 +376,9 @@
>        dst.Reserved0 = src.Reserved0
>        dst.Reserved1 = src.Reserved1
>
> -       // The src is 1 element shorter than dst. Zero that last one.
> +       // The src is 1 element bigger than dst, but it must be NUL.
>        copy(dst.FileName[:], src.FileName[:])
> -       dst.FileName[len(dst.FileName)**-1] = 0
>        copy(dst.AlternateFileName[:], src.AlternateFileName[:])
> -       src.AlternateFileName[len(dst.**AlternateFileName)-1] = 0
>  }
>
>  type ByHandleFileInformation struct {
>
>
>

[rsc, 2012-06-13 20:44:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=5f4c5ee2f0ad ***

syscall: fix windows copyFindData

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6301076