Issue 6301048: Add client authentification support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6301048: Add client authentification support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Takashi Toyoshima

Modified:
13 years, 2 months ago

Reviewers:
tyoshino (chromium.org), bashi

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
https://pywebsocket.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add client authentification support BUG=none TEST=./test/run_all.py

Patch Set 1 #

Patch Set 2 : add cert for browser #

Patch Set 3 : add simple instruction #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -0 lines)			Patch
M	src/mod_pywebsocket/standalone.py	View	1 2	4 chunks	+31 lines, -1 line	1 comment	Download
A	src/test/cert/cacert.pem	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	src/test/cert/cert.pem	View		1 chunk	+61 lines, -0 lines	0 comments	Download
A	src/test/cert/client_cert.p12	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	src/test/cert/key.pem	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Takashi Toyoshima

Helo, bashi. I experimentally implement client authentication support. I try this change like, $ ./mod_pywebsocket/standalone.py ...

13 years, 2 months ago (2012-06-06 08:37:10 UTC) #1

bashi

LGTM. It might be better to write usage of the option somewhere. On 2012/06/06 08:37:10, ...

13 years, 2 months ago (2012-06-06 09:09:30 UTC) #2

tyoshino (chromium.org)

13 years, 2 months ago (2012-06-12 05:51:07 UTC) #3

LGTM

s/authentification/authentication/

https://codereview.appspot.com/6301048/diff/1005/src/mod_pywebsocket/standalo...
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/6301048/diff/1005/src/mod_pywebsocket/standalo...
src/mod_pywebsocket/standalone.py:885: logging.critical('Client authentication
requires ssl.')
s/ssl/ssl module/

Expand All Messages | Collapse All Messages