fix warnings on Mac in samplecode

fix warnings on Mac in ssamplecode

Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation

The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Committed: https://code.google.com/p/skia/source/detail?r=4183

[bsalomon, 2012-06-05 19:16:58]

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp#newcode602
samplecode/SampleApp.cpp:602: GrContext* GetGr();
wow

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp
File samplecode/SampleOverflow.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp#ne...
samplecode/SampleOverflow.cpp:59: #ifdef SK_SCALAR_IS_FLOATx
I see we do this in other places but I don't get it. Is there actually a macro
with this name or is effectively "#if 0" but documenting that the code only
works for scalar=float?

[bsalomon, 2012-06-05 19:19:57]

On 2012/06/05 19:16:58, bsalomon wrote:
> http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp
> File samplecode/SampleApp.cpp (right):
> 
>
http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp#newcode602
> samplecode/SampleApp.cpp:602: GrContext* GetGr();
> wow
> 
> http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp
> File samplecode/SampleOverflow.cpp (right):
> 
>
http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp#ne...
> samplecode/SampleOverflow.cpp:59: #ifdef SK_SCALAR_IS_FLOATx
> I see we do this in other places but I don't get it. Is there actually a macro
> with this name or is effectively "#if 0" but documenting that the code only
> works for scalar=float?

Oh, and LGTM.

[epoger, 2012-06-05 19:47:02]

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleBlur.cpp
File samplecode/SampleBlur.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleBlur.cpp#newcode56
samplecode/SampleBlur.cpp:56: fBM = make_bitmap();
please add comment saying why

or, alternatively...

#ifdef COMPILE_UNUSED_CODE_TO_KEEP_IT_FROM_ROTTING
   blah;
#endif


That would serve two purposes: indicating why, and allowing us to easily toggle
for whatever reason.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleCircle.cpp
File samplecode/SampleCircle.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleCircle.cpp#newc...
samplecode/SampleCircle.cpp:61: test_circlebounds(canvas);
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleColorFilter.cpp
File samplecode/SampleColorFilter.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleColorFilter.cpp...
samplecode/SampleColorFilter.cpp:136: if (false) {
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleGradients.cpp
File samplecode/SampleGradients.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleGradients.cpp#n...
samplecode/SampleGradients.cpp:171: if (false) {
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleLineClipper.cpp
File samplecode/SampleLineClipper.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleLineClipper.cpp...
samplecode/SampleLineClipper.cpp:212: if (false) {
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleRegion.cpp
File samplecode/SampleRegion.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleRegion.cpp#newc...
samplecode/SampleRegion.cpp:326: if (false) {
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleStrokeText.cpp
File samplecode/SampleStrokeText.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleStrokeText.cpp#...
samplecode/SampleStrokeText.cpp:135: lettersToBitmap2(&bm, "Test Case", paint,
SkBitmap::kARGB_4444_Config);
please add comment saying why

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleTextAlpha.cpp
File samplecode/SampleTextAlpha.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleTextAlpha.cpp#n...
samplecode/SampleTextAlpha.cpp:86: if (false) {
please add comment saying why

[caryclark1, 2012-06-05 20:29:42]

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleApp.cpp#newcode602
samplecode/SampleApp.cpp:602: GrContext* GetGr();
Added comment (FIXME) to document moving this to a header.
On 2012/06/05 19:16:58, bsalomon wrote:
> wow

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleBlur.cpp
File samplecode/SampleBlur.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleBlur.cpp#newcode56
samplecode/SampleBlur.cpp:56: fBM = make_bitmap();
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why
> 
> or, alternatively...
> 
> #ifdef COMPILE_UNUSED_CODE_TO_KEEP_IT_FROM_ROTTING
>    blah;
> #endif
> 
> 
> That would serve two purposes: indicating why, and allowing us to easily
toggle
> for whatever reason.

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleCircle.cpp
File samplecode/SampleCircle.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleCircle.cpp#newc...
samplecode/SampleCircle.cpp:61: test_circlebounds(canvas);
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleColorFilter.cpp
File samplecode/SampleColorFilter.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleColorFilter.cpp...
samplecode/SampleColorFilter.cpp:136: if (false) {
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleGradients.cpp
File samplecode/SampleGradients.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleGradients.cpp#n...
samplecode/SampleGradients.cpp:171: if (false) {
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleLineClipper.cpp
File samplecode/SampleLineClipper.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleLineClipper.cpp...
samplecode/SampleLineClipper.cpp:212: if (false) {
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp
File samplecode/SampleOverflow.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleOverflow.cpp#ne...
samplecode/SampleOverflow.cpp:59: #ifdef SK_SCALAR_IS_FLOATx
Added comment to document your question. I don't know either.
On 2012/06/05 19:16:58, bsalomon wrote:
> I see we do this in other places but I don't get it. Is there actually a macro
> with this name or is effectively "#if 0" but documenting that the code only
> works for scalar=float?

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleRegion.cpp
File samplecode/SampleRegion.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleRegion.cpp#newc...
samplecode/SampleRegion.cpp:326: if (false) {
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleStrokeText.cpp
File samplecode/SampleStrokeText.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleStrokeText.cpp#...
samplecode/SampleStrokeText.cpp:135: lettersToBitmap2(&bm, "Test Case", paint,
SkBitmap::kARGB_4444_Config);
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleTextAlpha.cpp
File samplecode/SampleTextAlpha.cpp (right):

http://codereview.appspot.com/6301044/diff/1/samplecode/SampleTextAlpha.cpp#n...
samplecode/SampleTextAlpha.cpp:86: if (false) {
On 2012/06/05 19:47:02, epoger wrote:
> please add comment saying why

Done.