Issue 6300069: add unitRelationWatcher/unitRelationChange types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6300069: add unitRelationWatcher/unitRelationChange types

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fwereade

Modified:
12 years, 5 months ago

Reviewers:
mp+109305

Visibility:
Public.

Description

add unitRelationWatcher/unitRelationChange types The additions are entirely internal to the state package, because they will be used only by a (forthcoming) RelatedUnitsWatcher, which will need to keep an eye on N of these at the same time. Therefore, the tests are internal as well, to avoid bloating export_test; and, in the absence of the UnitRelation type, are written against hand-hacked zk state. The tests for RelatedUnitsWatcher will be external, and written against real UnitRelation state. https://code.launchpad.net/~fwereade/juju-core/unit-relation-watcher/+merge/109305 Requires: https://code.launchpad.net/~fwereade/juju-core/version-watcher/+merge/109310 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+283 lines, -14 lines)			Patch
A	[revision details]	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/internal_test.go	View	1 2 3 4 5 6	4 chunks	+123 lines, -14 lines	0 comments	Download
M	state/watcher.go	View	1 2 3 4 5 6	2 chunks	+158 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

fwereade

12 years, 5 months ago (2012-06-11 11:43:19 UTC) #6

On 2012/06/11 07:29:34, fwereade wrote:
> Please take a look.

Rejecting for now; rejected prereq, need to rework this to use ContentWatcher.

Expand All Messages | Collapse All Messages