Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 6299062: Rename the existing flatten(void*) methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by DerekS
Modified:
12 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Rename the existing flatten(void*) methods. This change avoids naminc confusion with the SkFlattenable flatten methods and also changes SkPath to use the void* model instead of taking a SkReader32. Committed: https://code.google.com/p/skia/source/detail?r=4215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -64 lines) Patch
M include/core/SkMatrix.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/core/SkOrderedReadBuffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkOrderedWriteBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPath.h View 1 chunk +10 lines, -2 lines 0 comments Download
M include/core/SkReader32.h View 2 chunks +9 lines, -2 lines 0 comments Download
M include/core/SkRegion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkWriter32.h View 2 chunks +11 lines, -4 lines 0 comments Download
M samplecode/SampleRegion.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 3 chunks +19 lines, -7 lines 0 comments Download
M src/core/SkRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 8 chunks +10 lines, -26 lines 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
DerekS
12 years, 6 months ago (2012-06-08 17:25:39 UTC) #1
reed1
lgtm -- can we augment the PathTest to check the returned size if we pass ...
12 years, 6 months ago (2012-06-08 18:16:18 UTC) #2
reed1
we might try to locally patch this into a chrome build, and be sure it ...
12 years, 6 months ago (2012-06-08 18:16:58 UTC) #3
DerekS
12 years, 6 months ago (2012-06-08 18:29:44 UTC) #4
On 2012/06/08 18:16:58, reed1 wrote:
> we might try to locally patch this into a chrome build, and be sure it
compiles
> (i.e. does chrome use the old APIs anywhere?)

I've added the test and I'm updating my local copy of Chrome now so that I can
locally patch chrome to test the change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b