Issue 6299058: Move ProgramBinary into new file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6299058: Move ProgramBinary into new file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by apatrick1

Modified:
12 years, 3 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Move ProgramBinary into new file. Committed: https://code.google.com/p/angleproject/source/detail?r=1144

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3210 lines)			Patch
M	src/build_angle.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/libGLESv2/Context.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/libGLESv2/Program.h	View	2 chunks	+0 lines, -195 lines	0 comments	Download
M	src/libGLESv2/Program.cpp	View	18 chunks	+1 line, -2559 lines	0 comments	Download
A +	src/libGLESv2/ProgramBinary.h	View	2 chunks	+3 lines, -81 lines	0 comments	Download
A +	src/libGLESv2/ProgramBinary.cpp	View	17 chunks	+1 line, -375 lines	0 comments	Download
M	src/libGLESv2/VertexDataManager.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.vcproj	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 2

apatrick1

Daniel, Step 3. I'll work on actually implementing the extension next. Al

12 years, 3 months ago (2012-06-07 21:36:44 UTC) #1

dgkoch

12 years, 3 months ago (2012-06-08 00:18:30 UTC) #2

LGTM - thanks for splitting this up. Was much easier to review.