Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(731)

Issue 6299047: fix warnings on Mac in src/pdf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by caryclark1
Modified:
12 years, 2 months ago
Reviewers:
Steve VanDeBogart
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

fix warnings on Mac in src/pdf Fix these class of warnings: - unused functions - unused locals - sign mismatch - missing function prototypes - missing newline at end of file - 64 to 32 bit truncation The changes prefer to link in dead code in the debug build with 'if (false)' than to comment it out, but trivial cases are commented out or sometimes deleted if it appears to be a copy/paste error. Committed: https://code.google.com/p/skia/source/detail?r=4178

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M src/pdf/SkPDFCatalog.cpp View 1 chunk +1 line, -1 line 1 comment Download
M src/pdf/SkPDFDocument.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/pdf/SkPDFPage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
caryclark1
12 years, 3 months ago (2012-06-05 19:19:41 UTC) #1
Steve VanDeBogart
12 years, 2 months ago (2012-06-17 02:10:37 UTC) #2
https://codereview.appspot.com/6299047/diff/2002/src/pdf/SkPDFCatalog.cpp
File src/pdf/SkPDFCatalog.cpp (right):

https://codereview.appspot.com/6299047/diff/2002/src/pdf/SkPDFCatalog.cpp#new...
src/pdf/SkPDFCatalog.cpp:41: size_t SkPDFCatalog::setFileOffset(SkPDFObject*
obj, size_t offset) {
Thanks for the cleanup.  Would it work to just change the argument type to off_t
instead of size_t here? fFileOffset appears to be an off_t anyway.  I think that
would remove a lot of the casts that you had to add.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b