Issue 6298043: Implements InputContext::Observer::updateInputText and updateCursor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6298043: Implements InputContext::Observer::updateInputText and updateCursor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by hsumita1

Modified:
11 years, 11 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Implements InputContext::Observer::updateInputText and updateCursor BUG=None TEST=Manual

Patch Set 4 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -6 lines)			Patch
M	configure.ac	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PyZyBopomofoContext.cc	View		12 chunks	+16 lines, -2 lines	0 comments	Download
M	src/PyZyDoublePinyinContext.cc	View	1	13 chunks	+21 lines, -0 lines	0 comments	Download
M	src/PyZyFullPinyinContext.cc	View		10 chunks	+13 lines, -1 line	0 comments	Download
M	src/PyZyInputContext.h	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/PyZyPhoneticContext.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/PyZyPhoneticContext.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download
M	src/PyZyPinyinContext.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/PyZySpecialPhraseTable.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

Why resubmit CL https://codereview.appspot.com/6250045 again? https://codereview.appspot.com/6298043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/6298043/diff/1/configure.ac#newcode26 configure.ac:26: m4_define([pyzy_minor_version], [1]) How about ...

11 years, 11 months ago (2012-06-05 14:38:31 UTC) #2

hsumita1

> Why resubmit CL https://codereview.appspot.com/6250045 again? Sorry, it's my mistake. I fixed configure.ac and revert ...

11 years, 11 months ago (2012-06-06 04:53:42 UTC) #3

Peng

On 2012/06/06 04:53:42, hsumita1 wrote: > > Why resubmit CL https://codereview.appspot.com/6250045 again? > > Sorry, ...

11 years, 11 months ago (2012-06-06 14:15:59 UTC) #4

Peng

11 years, 11 months ago (2012-06-06 18:45:15 UTC) #5

Please also remove [Review URL:xxx] in CL description.
On 2012/06/06 14:15:59, Peng wrote:
> On 2012/06/06 04:53:42, hsumita1 wrote:
> > > Why resubmit CL https://codereview.appspot.com/6250045 again?
> > 
> > Sorry, it's my mistake.
> > 
> > I fixed configure.ac and revert PyZyDatabase.cc.
> 
> lgtm

Expand All Messages | Collapse All Messages