Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 6297103: Fixed build for manually-maintained vcproj files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Alok Priyadarshi
Modified:
13 years, 10 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed build for manually-maintained vcproj files. Committed: https://code.google.com/p/angleproject/source/detail?r=1159

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -30 lines) Patch
M src/ANGLE.sln View 3 chunks +12 lines, -1 line 0 comments Download
A src/compiler/preprocessor/new/preprocessor.vcproj View 1 1 chunk +261 lines, -0 lines 0 comments Download
M src/compiler/translator_common.vcproj View 13 chunks +49 lines, -29 lines 0 comments Download

Messages

Total messages: 7
Alok Priyadarshi
13 years, 10 months ago (2012-06-19 18:10:48 UTC) #1
kbr1
I leave this review to Daniel.
13 years, 10 months ago (2012-06-19 18:21:49 UTC) #2
dgkoch
I'm getting a build failure due to warnings treated as errors and the following unreachable ...
13 years, 10 months ago (2012-06-19 18:29:32 UTC) #3
Alok Priyadarshi
On 2012/06/19 18:29:32, dgkoch wrote: > I'm getting a build failure due to warnings treated ...
13 years, 10 months ago (2012-06-19 18:38:57 UTC) #4
dgkoch
Thanks. LGTM (and WFM!)
13 years, 10 months ago (2012-06-19 18:51:26 UTC) #5
dgkoch
BTW the x64 target is missing in the new project (but the 64-bit build also ...
13 years, 10 months ago (2012-06-19 18:55:59 UTC) #6
Alok Priyadarshi
13 years, 10 months ago (2012-06-19 19:44:33 UTC) #7
On 2012/06/19 18:55:59, dgkoch wrote:
> BTW the x64 target is missing in the new project (but the 64-bit build also
> seems to be broken before this due to some warnings that are treated as
> errors...)

Ah.. did not know about x64. Will fix shortly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b