Issue 6296067: [android] Add an API to load customized font config for testing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6296067: [android] Add an API to load customized font config for testing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Hao Zheng

Modified:
12 years, 2 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

[android] Add an API to load customized font config for testing. When running WebKit layout tests, we need to load some fonts from Linux to match baselines of chromium linux. However, font config file is hard-coded in Skia now. This change add an API to customize font config in skia.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -16 lines)			Patch
M	include/ports/SkTypeface_android.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ports/FontHostConfiguration_android.h	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	src/ports/FontHostConfiguration_android.cpp	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_android.cpp	View	10 chunks	+40 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DerekS

12 years, 2 months ago (2012-07-20 12:16:31 UTC) #5

On 2012/06/25 13:59:14, DerekS wrote:
> On 2012/06/25 07:07:08, Hao Zheng wrote:
> 
> committed r4316

please close this issue since the code has been committed.

Expand All Messages | Collapse All Messages