Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1374)

Issue 6296044: fix warnings on Mac in src/gpu (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by caryclark1
Modified:
12 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

fix warnings on Mac in src/gpu and include/gpu Fix these class of warnings: - unused functions - unused locals - sign mismatch - missing function prototypes - missing newline at end of file - 64 to 32 bit truncation The changes prefer to link in dead code in the debug build with 'if (false)' than to comment it out, but trivial cases are commented out or sometimes deleted if it appears to be a copy/paste error. Committed: https://code.google.com/p/skia/source/detail?r=4180

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M include/gpu/GrProgramStageFactory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/SkGr.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrMemory.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMorphologyEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 7 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/debug/GrFrameBufferObj.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/mac/SkNativeGLContext_mac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gr_unittests.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bsalomon
A bunch of the dead funcs and vars can just be deleted. However, I'd say ...
12 years, 5 months ago (2012-06-05 19:10:53 UTC) #1
caryclark1
12 years, 5 months ago (2012-06-05 19:20:45 UTC) #2

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b