Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1116)

Issue 6295050: Add tiled rendering as an option to GM. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by Leon
Modified:
12 years, 5 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add tiled rendering as an option to GM. Use an SkGPipe to play back drawing into tiles. This will help us to debug differences in drawing while tiled. Pass --tiledPipe to gm to use the tiled pipe. Committed: https://code.google.com/p/skia/source/detail?r=4199

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -42 lines) Patch
M gm/gmmain.cpp View 1 2 3 8 chunks +35 lines, -40 lines 0 comments Download
M gyp/gm.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M include/pipe/SkGPipe.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
A src/pipe/utils/SamplePipeControllers.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A src/pipe/utils/SamplePipeControllers.cpp View 1 2 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Leon
12 years, 5 months ago (2012-06-06 18:58:24 UTC) #1
reed1
lets extract the TileController into a sample file for reuse https://codereview.appspot.com/6295050/diff/1/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp (right): https://codereview.appspot.com/6295050/diff/1/src/pipe/SkGPipeRead.cpp#newcode559 ...
12 years, 5 months ago (2012-06-06 19:09:16 UTC) #2
Leon
Moved TiledPipeController into its own files. https://codereview.appspot.com/6295050/diff/1/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp (right): https://codereview.appspot.com/6295050/diff/1/src/pipe/SkGPipeRead.cpp#newcode559 src/pipe/SkGPipeRead.cpp:559: void SkGPipeReader::setCanvas(SkCanvas *target) ...
12 years, 5 months ago (2012-06-06 19:45:11 UTC) #3
reed1
If you want, you can commit the SkGPipeReader files now, since that change (adding setCanvas) ...
12 years, 5 months ago (2012-06-06 20:39:53 UTC) #4
Leon
https://codereview.appspot.com/6295050/diff/3002/src/pipe/utils/SamplePipeControllers.h File src/pipe/utils/SamplePipeControllers.h (right): https://codereview.appspot.com/6295050/diff/3002/src/pipe/utils/SamplePipeControllers.h#newcode14 src/pipe/utils/SamplePipeControllers.h:14: public: On 2012/06/06 20:39:53, reed1 wrote: > Why do ...
12 years, 5 months ago (2012-06-06 20:49:55 UTC) #5
reed1
12 years, 5 months ago (2012-06-06 20:53:39 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b