Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)

Issue 6294055: code review 6294055: regexp/syntax: unexport ErrUnexpectedParen (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

regexp/syntax: unexport ErrUnexpectedParen This new error is the only API change in the current draft of Go 1.0.2 CLs. I'd like to include the CL that introduced it, because it replaces a mysterious 'internal error' with a useful error message, but I don't want any API changes, so unexport the error constant for now. It can be re-exported for Go 1.1.

Patch Set 1 #

Patch Set 2 : diff -r f88086a3bb34 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r f88086a3bb34 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/regexp/syntax/parse.go View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-06-08 16:47:44 UTC) #1
r
LGTM http://codereview.appspot.com/6294055/diff/2001/src/pkg/regexp/syntax/parse.go File src/pkg/regexp/syntax/parse.go (right): http://codereview.appspot.com/6294055/diff/2001/src/pkg/regexp/syntax/parse.go#newcode51 src/pkg/regexp/syntax/parse.go:51: const errUnexpectedParen ErrorCode = "unexpected )" // TODO: ...
12 years, 9 months ago (2012-06-08 16:54:51 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=b4cdcec897fb *** regexp/syntax: unexport ErrUnexpectedParen This new error is the only API ...
12 years, 9 months ago (2012-06-08 17:05:08 UTC) #3
rsc
12 years, 9 months ago (2012-06-08 17:05:15 UTC) #4
On Fri, Jun 8, 2012 at 12:54 PM,  <r@golang.org> wrote:
> // TODO: export for Go 1.1.

done, and created issue 3712.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b