Issue 6294051: Remvoes unused or not-maintained files.

Issue 6294051: Remvoes unused or not-maintained files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by hsumita1

Modified:
14 years ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang, Peng

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Remvoes unused or not-maintained files. BUG=None TEST=Manual

Patch Set 2 : #

Total comments: 4

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1622 lines)			Patch
D	debian/changelog.in	View		1 chunk	+0 lines, -5 lines	0 comments	Download
D	debian/compat	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	debian/control	View		1 chunk	+0 lines, -51 lines	0 comments	Download
D	debian/copyright	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	debian/docs	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	debian/ibus-pinyin.lintian-overrides	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	debian/rules	View		1 chunk	+0 lines, -110 lines	0 comments	Download
D	debian/source/format	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	debian/watch	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	scripts/genpuncttable.py	View		1 chunk	+0 lines, -32 lines	0 comments	Download
D	scripts/punct.py	View		1 chunk	+0 lines, -100 lines	2 comments	Download
M	src/Makefile.am	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/PyZyTest.cc	View	1	1 chunk	+0 lines, -1275 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/6294051/diff/3001/scripts/punct.py File scripts/punct.py (left): http://codereview.appspot.com/6294051/diff/3001/scripts/punct.py#oldcode2 scripts/punct.py:2: # -*- coding: utf-8 -*- Are those scripts not ...

14 years ago (2012-06-08 14:40:25 UTC) #2

hsumita1

14 years ago (2012-06-11 09:22:23 UTC) #3

Peng

14 years ago (2012-06-11 13:45:51 UTC) #4

lgtm

On 2012/06/11 09:22:23, hsumita1 wrote:
> http://codereview.appspot.com/6294051/diff/3001/scripts/punct.py
> File scripts/punct.py (left):
> 
> http://codereview.appspot.com/6294051/diff/3001/scripts/punct.py#oldcode2
> scripts/punct.py:2: # -*- coding: utf-8 -*-
> It seems that punct.py is not referenced by any files on ibus-pinyin and pyzy.
> 
> At least, pyzy doesn't need it since pyzy doesn't handle punctuation
characters,
> so I removed it.
> 
> http://codereview.appspot.com/6294051/diff/3001/src/PyZyTest.cc
> File src/PyZyTest.cc (left):
> 
> http://codereview.appspot.com/6294051/diff/3001/src/PyZyTest.cc#oldcode1
> src/PyZyTest.cc:1: /* vim:set et ts=4 sts=4:
> Yes, it is not maintained.
> 
> I have just started to maintain this test file, and I will submit it later.

Expand All Messages | Collapse All Messages