Issue 6294043: Fixes a bug caused by a reallocation on vector.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6294043: Fixes a bug caused by a reallocation on vector. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by hsumita1

Modified:
11 years, 10 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang, Peng

Base URL:
git://github.com/ibus/ibus-pinyin.git@master

Visibility:
Public.

More Reviews

Description

Fixes a bug caused by a reallocation on vector. BUG=Database::query crashes on some situation TEST=Manual

Patch Set 1 #

Patch Set 2 : Add comments. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/PYDatabase.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

lgtm. But don't understand why origin code has problem. Please explain it. Thanks.

11 years, 10 months ago (2012-06-05 14:09:32 UTC) #2

Peng

On 2012/06/05 14:09:32, Peng wrote: > lgtm. But don't understand why origin code has problem. ...

11 years, 10 months ago (2012-06-05 14:15:15 UTC) #3

hsumita1

Please see also http://cplusplus.com/reference/stl/vector/push_back/ > This effectively increases the vector size by one, which causes ...

11 years, 10 months ago (2012-06-06 05:04:04 UTC) #4

Peng

11 years, 10 months ago (2012-06-06 14:18:58 UTC) #5

On 2012/06/06 05:04:04, hsumita1 wrote:
> Please see also
> 
> http://cplusplus.com/reference/stl/vector/push_back/
> > This effectively increases the vector size by one, which causes a
reallocation
> of the internal allocated
> > storage if the vector size was equal to the vector capacity before the call.
> Reallocations invalidate all
> > previously obtained iterators, references and pointers.
> 
> By this error, Database::query returns NULL pointer, and ibus-pinyin crashes
on
> g_assert on Query::fill.

I see. Thank you.

Expand All Messages | Collapse All Messages