Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 6287045: Scale up non-multiple-of-4 dxt textures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by John Bauman
Modified:
11 years, 9 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Scale up non-multiple-of-4 dxt textures D3D doesn't support DXT textures that aren't a multiple of 4 in size, so multiply the sizes by 2 or 4 so they work. Then ensure sampler parameters are set up correctly so they don't sample the unuploaded miplevels. BUG=https://code.google.com/p/angleproject/issues/detail?id=237 TEST= Committed: https://code.google.com/p/angleproject/source/detail?r=1222

Patch Set 1 #

Patch Set 2 : Rebase against newer version #

Patch Set 3 : Don't expand 4x4 or larger textures #

Patch Set 4 : Only if less than 4x4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -22 lines) Patch
M src/libGLESv2/Context.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/Texture.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M src/libGLESv2/Texture.cpp View 1 2 3 9 chunks +41 lines, -21 lines 0 comments Download
M src/libGLESv2/utilities.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/utilities.cpp View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5
John Bauman
11 years, 11 months ago (2012-06-05 00:28:55 UTC) #1
dgkoch
Subject to my elsewhere noted concerns, this seems ok. However it is based on old ...
11 years, 11 months ago (2012-06-07 03:53:55 UTC) #2
John Bauman
On 2012/06/07 03:53:55, dgkoch wrote: > Subject to my elsewhere noted concerns, this seems ok. ...
11 years, 11 months ago (2012-06-07 07:33:58 UTC) #3
John Bauman
Ok, here's a new version that's restricted to textures that have one dimension less than ...
11 years, 10 months ago (2012-07-11 00:13:18 UTC) #4
dgkoch
11 years, 9 months ago (2012-07-12 02:53:25 UTC) #5
LGTM.

We'll also need to validate the sizes in libGLESv2, but I can handle that when I
update the extension (unless you beat me to it!).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b