Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(596)

Issue 6279044: code review 6279044: api: add FreeBSD to go1 API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by bradfitz
Modified:
12 years, 9 months ago
Reviewers:
minux1
CC:
golang-dev, r
Visibility:
Public.

Description

api: add FreeBSD to go1 API Now that gri has made go/parser 15% faster, I offer this change to slow back down cmd/api ~proportionately, adding FreeBSD to the go1-checked set of platforms. Really we should have done this earlier. This will prevent us from breaking FreeBSD compatibility accidentally in the future.

Patch Set 1 #

Patch Set 2 : diff -r 5eb6fe483779 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5eb6fe483779 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0b9ae2971811 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4064 lines, -7 lines) Patch
M api/go1.txt View 36 chunks +4062 lines, -7 lines 0 comments Download
M src/cmd/api/goapi.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-06-02 01:17:37 UTC) #1
r
LGTM
12 years, 9 months ago (2012-06-02 01:35:10 UTC) #2
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=d8e47164f8dd *** api: add FreeBSD to go1 API Now that gri has ...
12 years, 9 months ago (2012-06-02 01:42:43 UTC) #3
minux1
On Sat, Jun 2, 2012 at 9:42 AM, <bradfitz@golang.org> wrote: > api: add FreeBSD to ...
12 years, 9 months ago (2012-06-02 23:34:39 UTC) #4
bradfitz
12 years, 9 months ago (2012-06-02 23:48:02 UTC) #5
Yes.
On Jun 2, 2012 4:34 PM, "minux" <minux.ma@gmail.com> wrote:

>
> On Sat, Jun 2, 2012 at 9:42 AM, <bradfitz@golang.org> wrote:
>
>> api: add FreeBSD to go1 API
>>
> Linux/ARM is also officially supported by Go 1, should we also test for it?
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b