Fix an issue where Pipe did not draw correctly

Fix an issue where Pipe did not draw correctly
on all platforms.

Since parameters can be evaluated in any order,
we can't call buffer.read() inline for multiple
parameters. The fix is to read the stream (in
the correct order) before we call the function.
Committed: https://code.google.com/p/skia/source/detail?r=4160

[reed1, 2012-06-05 13:08:07]

The CL comment could be more specific (as a learning aid), e.g.

Since parameters can be evaluated in any order, we can't call buffer.read()
inline for multiple parameters. The fix is to read the stream (in the correct
order) before we call the function.

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (left):

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:368: reader->readInt(), reader->readInt());
skip<SkIRect>(reader) ?

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:383: reader->readInt(), reader->readInt());
skip<SkIRect>(reader) ?

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:396: hasPaint ? &state->paint() : NULL);
skip<SkIPoint>(reader) ?

[Leon, 2012-06-05 14:44:21]

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (left):

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:368: reader->readInt(), reader->readInt());
On 2012/06/05 13:08:07, reed1 wrote:
> skip<SkIRect>(reader) ?

Done.

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:383: reader->readInt(), reader->readInt());
On 2012/06/05 13:08:07, reed1 wrote:
> skip<SkIRect>(reader) ?

Done.

https://codereview.appspot.com/6277046/diff/1/src/pipe/SkGPipeRead.cpp#oldcod...
src/pipe/SkGPipeRead.cpp:396: hasPaint ? &state->paint() : NULL);
On 2012/06/05 13:08:07, reed1 wrote:
> skip<SkIPoint>(reader) ?

Done.

[reed1, 2012-06-05 14:57:15]

lgtm