Issue 6277045: Add legacy script to enable skia roll into chromium.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6277045: Add legacy script to enable skia roll into chromium. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by DerekS

Modified:
12 years, 3 months ago

Reviewers:
Hao Zheng, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add legacy script to enable skia roll into chromium. Committed: https://code.google.com/p/skia/source/detail?r=4137

Patch Set 1 #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	include/ports/SkTypeface_android.h	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/6277045/diff/1/include/ports/SkTypeface_android.h File include/ports/SkTypeface_android.h (right): http://codereview.appspot.com/6277045/diff/1/include/ports/SkTypeface_android.h#newcode36 include/ports/SkTypeface_android.h:36: ((unsigned)(s) < kFallbackScriptNumber)

12 years, 3 months ago (2012-06-04 14:07:51 UTC) #3

Hao Zheng

12 years, 3 months ago (2012-06-05 03:04:23 UTC) #4

On 2012/06/04 14:07:51, reed1 wrote:
>
http://codereview.appspot.com/6277045/diff/1/include/ports/SkTypeface_android.h
> File include/ports/SkTypeface_android.h (right):
> 
>
http://codereview.appspot.com/6277045/diff/1/include/ports/SkTypeface_android...
> include/ports/SkTypeface_android.h:36: 
> ((unsigned)(s) < kFallbackScriptNumber)

Thanks, Derek. I will upstream the WebKit part.

Expand All Messages | Collapse All Messages