Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1053)

Issue 6276044: Make the GM tool run GMs through an SkGPipe. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Leon
Modified:
11 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make the GM tool run GMs through an SkGPipe. Add pipe to core gyp project. Do not run samplerstress through the pipe, since its custom MaskFilter will not draw correctly. Fix an assert in SkGPipeWrite when writing a typeface.

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -11 lines) Patch
M gm/gm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M gm/gmmain.cpp View 1 7 chunks +74 lines, -1 line 0 comments Download
M gm/samplerstress.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 chunks +1 line, -6 lines 0 comments Download
M gyp/core.gyp View 1 3 chunks +4 lines, -0 lines 0 comments Download
M gyp/gm.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Leon
11 years, 11 months ago (2012-06-01 21:00:53 UTC) #1
Leon
https://codereview.appspot.com/6276044/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.appspot.com/6276044/diff/1/gm/gmmain.cpp#newcode281 gm/gmmain.cpp:281: canvas->concat(gm->getInitialTransform()); This change is not necessary for this CL. ...
11 years, 11 months ago (2012-06-04 14:08:51 UTC) #2
reed1
maybe its time to just roll the pipe code into gyp/core https://codereview.appspot.com/6276044/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): ...
11 years, 11 months ago (2012-06-04 14:27:40 UTC) #3
Leon
In my next CL, I have added the pipe files to core, removed pipe.gyp, and ...
11 years, 11 months ago (2012-06-04 14:52:49 UTC) #4
reed1
11 years, 11 months ago (2012-06-04 16:06:57 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b