Use IM icon in switcher dialog.

Use IM icon in switcher dialog.


BUG=None
TEST=Manually

[Peng, 2012-06-04 14:34:40]

I find the symbol icons are not clear sometimes. Especially, users have two or
more engines for same language. All of those engines will use same symbol icon.
I think it is not very good.

With this CL, Ibus will use IM icon instead of symbol icon by default. If down
stream wants to use symbol icon, they could patch switcher.vala to modify the
flag.

Peng

[fujiwara, 2012-06-05 02:31:50]

On 2012/06/04 14:34:40, Peng wrote:
> I find the symbol icons are not clear sometimes. Especially, users have two or
> more engines for same language. All of those engines will use same symbol
icon.
> I think it is not very good.
> 
> With this CL, Ibus will use IM icon instead of symbol icon by default. If down
> stream wants to use symbol icon, they could patch switcher.vala to modify the
> flag.
> 
> Peng

lgtm.

I think the image icon is bigger than metacity's Alt-Tab icon.
I like to move the settings into Makefile instead below so that I run 'make
USE_SYMBOL_ICON=TRUE'.
gnome-shell uses suffix numbers with U+2081 for the duplicated symbols and I can
port them easily.

--- ui/gtk3/Makefile.am.orig
+++ ui/gtk3/Makefile.am
@@ -42,6 +42,8 @@ INCLUDES = \
 	-I$(top_builddir)/src \
 	$(NULL)
 
+USE_SYMBOL_ICON = FALSE
+
 AM_CFLAGS = \
 	@GLIB2_CFLAGS@ \
 	@GIO2_CFLAGS@ \
@@ -57,6 +59,7 @@ AM_CFLAGS = \
 	-DBINDIR=\"@bindir@\" \
     -DIBUS_DISABLE_DEPRECATED \
 	-DIBUS_VERSION=\"@IBUS_VERSION@\" \
+	-DSWITCHER_USE_SYMBOL_ICON=$(USE_SYMBOL_ICON) \
 	-Wno-unused-variable \
 	-Wno-unused-but-set-variable \
 	-Wno-unused-function \
--- ui/gtk3/switcher.vala.orig	2012-06-05 11:20:43.764497732 +0900
+++ ui/gtk3/switcher.vala	2012-06-05 11:21:24.109199040 +0900
@@ -29,10 +29,10 @@ using IBus;
 using Pango;
 
 class Switcher : Gtk.Window {
+    public extern const bool USE_SYMBOL_ICON;
     private const int DEFAULT_FONT_SIZE = 16;
     private const int DESC_LABEL_MAX_LEN = 20;
     private const int ICON_SIZE = 48;
-    private const bool USE_SYMBOL_ICON = false;
 
     private class IBusEngineButton : Gtk.Button {
         public IBusEngineButton(IBus.EngineDesc engine) {

[Peng, 2012-06-05 13:59:33]

Update patch with your suggestion.