Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7605)

Issue 6273052: remove mutable apis on SkColorMatrixFilter, must use constructor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by reed1
Modified:
12 years, 6 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

remove mutable apis on SkColorMatrixFilter, must use constructor. fix flattening to not write function-ptrs (no go for serialization), so we store the raw float values now. Slight change to GM/DRT images for GPU possible. Just rebaseline. Committed: https://code.google.com/p/skia/source/detail?r=4143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -60 lines) Patch
M gm/colormatrix.cpp View 3 chunks +19 lines, -13 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +12 lines, -42 lines 0 comments Download

Messages

Total messages: 2
reed1
12 years, 6 months ago (2012-06-04 18:55:41 UTC) #1
bsalomon
12 years, 6 months ago (2012-06-04 19:04:13 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b