Issue 6273044: Apply SH_TIMING_RESTRICTIONS to all samplers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6273044: Apply SH_TIMING_RESTRICTIONS to all samplers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mvujovic

Modified:
13 years, 2 months ago

Reviewers:
kbr1, nicolas

CC:
angleproject-review_googlegroups.com, dgkoch

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This patch makes the SH_TIMING_RESTRICTIONS apply to all samplers. Right now, it only applies to samplers named "u_texture". This patch also removes some code in the dependency graph that built a map of global symbol names to graph nodes. We don't need this since we're not looking up specific samplers anymore. Issue: 332

Patch Set 1 #

Patch Set 2 : #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -112 lines)			Patch
M	src/compiler/Compiler.cpp	View		4 chunks	+8 lines, -16 lines	0 comments	Download
M	src/compiler/ShHandle.h	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	src/compiler/depgraph/DependencyGraph.h	View	1	4 chunks	+15 lines, -10 lines	0 comments	Download
M	src/compiler/depgraph/DependencyGraph.cpp	View	1	3 chunks	+4 lines, -18 lines	0 comments	Download
M	src/compiler/depgraph/DependencyGraphBuilder.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/compiler/depgraph/DependencyGraphBuilder.cpp	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	src/compiler/timing/RestrictFragmentShaderTiming.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/compiler/timing/RestrictFragmentShaderTiming.cpp	View	1	2 chunks	+17 lines, -16 lines	0 comments	Download
M	src/compiler/timing/RestrictVertexShaderTiming.h	View		1 chunk	+4 lines, -12 lines	0 comments	Download
M	src/compiler/timing/RestrictVertexShaderTiming.cpp	View		1 chunk	+3 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mvujovic

13 years, 2 months ago (2012-06-04 21:09:45 UTC) #4

On 2012/06/04 20:30:56, mvujovic wrote:
> Thanks for the review, guys. I'll commit it today.

Committed in r1131.

Expand All Messages | Collapse All Messages