Issue 627043: Join url rewritters to one dom walker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by zhoresh

Modified:
16 years ago

Reviewers:
johnfargo, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

In order to prevent rewritting urls that are already rewritten, just put concat and proxy into one dom walker

Created: 16 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingContentRewriter.java	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 3

johnfargo

16 years ago (2010-03-19 01:44:13 UTC) #3

Committed.

On Thu, Mar 18, 2010 at 6:27 PM, <johnfargo@gmail.com> wrote:

> LGTM, patching...
>
>
> http://codereview.appspot.com/627043/show
>