Issue 6267048: Initial specification for ANGLE_program_binary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6267048: Initial specification for ANGLE_program_binary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by apatrick1

Modified:
11 years, 11 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Initial specification for ANGLE_program_binary. Committed: https://code.google.com/p/angleproject/source/detail?r=1140

Patch Set 3 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -0 lines)			Patch
	A	extensions/ANGLE_program_binary.txt	View	1 2	1 chunk	+94 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dgkoch

overall LGTM https://codereview.appspot.com/6267048/diff/1/extensions/ANGLE_program_binary.txt File extensions/ANGLE_program_binary.txt (right): https://codereview.appspot.com/6267048/diff/1/extensions/ANGLE_program_binary.txt#newcode50 extensions/ANGLE_program_binary.txt:50: PROGRAM_BINARY_ANGLE 0x???? Let me know when you ...

11 years, 11 months ago (2012-06-06 18:41:16 UTC) #2

apatrick1

https://codereview.appspot.com/6267048/diff/1/extensions/ANGLE_program_binary.txt File extensions/ANGLE_program_binary.txt (right): https://codereview.appspot.com/6267048/diff/1/extensions/ANGLE_program_binary.txt#newcode50 extensions/ANGLE_program_binary.txt:50: PROGRAM_BINARY_ANGLE 0x???? On 2012/06/06 18:41:16, dgkoch wrote: > Let ...

11 years, 11 months ago (2012-06-06 19:19:56 UTC) #3

dgkoch

11 years, 11 months ago (2012-06-06 19:23:50 UTC) #4

LGTM with the minor fixes below.

https://codereview.appspot.com/6267048/diff/5001/extensions/ANGLE_program_bin...
File extensions/ANGLE_program_binary.txt (right):

https://codereview.appspot.com/6267048/diff/5001/extensions/ANGLE_program_bin...
extensions/ANGLE_program_binary.txt:24: Last Modifed Date: June 4, 2012
June 6 :-)

https://codereview.appspot.com/6267048/diff/5001/extensions/ANGLE_program_bin...
extensions/ANGLE_program_binary.txt:51: PROGRAM_BINARY_ANGLE        0x????
I've assigned 0x93A6 for this.

https://codereview.appspot.com/6267048/diff/5001/extensions/ANGLE_program_bin...
extensions/ANGLE_program_binary.txt:93: 06/04/2012  apatrick  intial revision
06/06

Expand All Messages | Collapse All Messages