Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 6261053: code review 6261053: syscall: correct Win32finddata definition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by brainman
Modified:
1 year, 10 months ago
Reviewers:
frichter
CC:
golang-dev, rsc
Visibility:
Public.

Description

syscall: correct Win32finddata definition

Fixes issue 3685.

Patch Set 1 #

Patch Set 2 : diff -r 3524a4743246 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3524a4743246 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a621ac756347 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a2cb3130bd86 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -9 lines) Patch
M api/next.txt View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M src/pkg/os/file_windows.go View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download
A src/pkg/syscall/syscall_windows_test.go View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 10 months ago #1
brainman
This breaks "go api" check, and I do not know what to do. Suggestions are ...
1 year, 10 months ago #2
rsc
It's annoying, but I think we need to define new types and functions. Specifically: 1. ...
1 year, 10 months ago #3
brainman
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 10 months ago #4
rsc
LGTM
1 year, 10 months ago #5
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=45d1063d8520 *** syscall: correct Win32finddata definition Fixes issue 3685. R=golang-dev, rsc CC=golang-dev ...
1 year, 10 months ago #6
frichter
Sorry for the 25th hour feedback. I just noticed this CL is being considered for ...
1 year, 10 months ago #7
rsc
You may be right. There is also CL 6244051. I'm going to talk to Andrew ...
1 year, 10 months ago #8
brainman
On 2012/06/07 04:01:29, rsc wrote: > You may be right. ... I think he is. ...
1 year, 10 months ago #9
rsc
On Thu, Jun 7, 2012 at 12:17 AM, <alex.brainman@gmail.com> wrote: > 2) If you take ...
1 year, 10 months ago #10
brainman
On 2012/06/07 04:23:18, rsc wrote: > > ... who wanted to be careful ... Isn't ...
1 year, 10 months ago #11
rsc
You're right - the old struct is useless and would have caused crashes (just mysterious ...
1 year, 10 months ago #12
brainman
On 2012/06/07 04:44:21, rsc wrote: > You're right - the old struct is useless and ...
1 year, 10 months ago #13
rsc
1 year, 10 months ago #14
On Wed, Jun 6, 2012 at 10:57 PM,  <hcwfrichter@gmail.com> wrote:
> Sorry for the 25th hour feedback.  I just noticed this CL is being
> considered for Go1.0.2, and I think that the approach here was wrong.

It's certainly true that we shouldn't do this for Go 1.0.2. Thank you
for reminding us.

I have sent out CL 6298063, which hides the new system calls and
structures and implements the old ones using them. This avoids any
visible API change and still gives access to the 8.3 name. For Go 1.1,
we might do something to avoid the overhead of the translation.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5