Issue 6260055: test-only: add test coverage of skdiff over input with identical bits or pixels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6260055: test-only: add test coverage of skdiff over input with identical bits or pixels (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by epoger

Modified:
12 years, 6 months ago

Reviewers:
(pls use tomhudson at google), TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

test-only: add test coverage of skdiff over input with identical bits or pixels Committed: https://code.google.com/p/skia/source/detail?r=4084

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
M	tools/tests/run.sh	View	1	1 chunk	+16 lines, -0 lines	1 comment	Download
A	tools/tests/skdiff/identical-bits-or-pixels/output-expected/command_line	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/identical-bits-or-pixels/output-expected/return_value	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/identical-bits-or-pixels/output-expected/stdout	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	tools/tests/skdiff/identical-bits/output-expected/command_line	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/identical-bits/output-expected/return_value	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/identical-bits/output-expected/stdout	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM. Nit: Could you add a comment to run.sh explaining why we have these particular ...

12 years, 6 months ago (2012-05-30 14:29:32 UTC) #2

epoger

12 years, 6 months ago (2012-05-30 14:36:03 UTC) #3

https://codereview.appspot.com/6260055/diff/4001/tools/tests/run.sh
File tools/tests/run.sh (right):

https://codereview.appspot.com/6260055/diff/4001/tools/tests/run.sh#newcode43
tools/tests/run.sh:43: # Run skdiff over a variety of file pair types: identical
bits, identical
Is this better?  If there are further adjustments that would help more, please
walk over and we can fix it together.

(My ulterior motive for this CL is to prepare for a change in which skdiff will
return nonzero exit value if there are mismatching images... this will allow me
to run skdiff, instead of gm, in the buildbots.)

Expand All Messages | Collapse All Messages