Issue 6259063: Store font family when serializing android fonts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6259063: Store font family when serializing android fonts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by DerekS

Modified:
12 years, 4 months ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Store font family when serializing android fonts. Committed: https://code.google.com/p/skia/source/detail?r=4114

Patch Set 1 #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	src/ports/SkFontHost_android.cpp	View		3 chunks	+29 lines, -5 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

12 years, 4 months ago (2012-06-01 15:30:00 UTC) #3

Aside from nits, LGTM.

http://codereview.appspot.com/6259063/diff/1/src/ports/SkFontHost_android.cpp
File src/ports/SkFontHost_android.cpp (right):

http://codereview.appspot.com/6259063/diff/1/src/ports/SkFontHost_android.cpp...
src/ports/SkFontHost_android.cpp:145: if(NULL == family) {
Skia usually has a space after the 'if'.

http://codereview.appspot.com/6259063/diff/1/src/ports/SkFontHost_android.cpp...
src/ports/SkFontHost_android.cpp:724: SkAutoMutexAcquire 
ac(gFamilyHeadAndNameListMutex);
Extra space?

Expand All Messages | Collapse All Messages