Issue 6258049: code review 6258049: cmd/8c: better fix for 64-bit register smash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6258049: code review 6258049: cmd/8c: better fix for 64-bit register smash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

cmd/8c: better fix for 64-bit register smash Ken pointed out that CL 5998043 was ugly code. This should be better. Fixes issue 3501.

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -28 lines)			Patch
	M	src/cmd/8c/cgen.c	View	1	2 chunks	+22 lines, -1 line	0 comments	Download
	M	src/cmd/8c/cgen64.c	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-25 03:36:24 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=00a25723a7cd *** cmd/8c: better fix for 64-bit register smash Ken pointed out ...

12 years, 9 months ago (2012-05-25 03:36:35 UTC) #2

lgtm