Issue 6257048: Refactored all tests to derive from a common PreprocessorTest. This avoids some code duplication.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6257048: Refactored all tests to derive from a common PreprocessorTest. This avoids some code duplication. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by Alok Priyadarshi

Modified:
11 years, 12 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Refactored all tests to derive from a common PreprocessorTest. This avoids some code duplication. Committed: https://code.google.com/p/angleproject/source/detail?r=1097

Patch Set 1 #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -348 lines)			Patch
M	tests/build_tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/preprocessor_tests/PreprocessorTest.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/char_test.cpp	View	3 chunks	+9 lines, -15 lines	0 comments	Download
M	tests/preprocessor_tests/comment_test.cpp	View	3 chunks	+16 lines, -24 lines	0 comments	Download
M	tests/preprocessor_tests/error_test.cpp	View	6 chunks	+10 lines, -23 lines	0 comments	Download
M	tests/preprocessor_tests/extension_test.cpp	View	7 chunks	+9 lines, -21 lines	0 comments	Download
M	tests/preprocessor_tests/identifier_test.cpp	View	3 chunks	+78 lines, -65 lines	0 comments	Download
M	tests/preprocessor_tests/input_test.cpp	View	1 chunk	+12 lines, -21 lines	0 comments	Download
M	tests/preprocessor_tests/location_test.cpp	View	8 chunks	+37 lines, -44 lines	0 comments	Download
M	tests/preprocessor_tests/number_test.cpp	View	7 chunks	+34 lines, -38 lines	0 comments	Download
M	tests/preprocessor_tests/operator_test.cpp	View	3 chunks	+5 lines, -11 lines	0 comments	Download
M	tests/preprocessor_tests/pragma_test.cpp	View	9 chunks	+11 lines, -25 lines	0 comments	Download
M	tests/preprocessor_tests/space_test.cpp	View	4 chunks	+34 lines, -48 lines	0 comments	Download
M	tests/preprocessor_tests/version_test.cpp	View	2 chunks	+3 lines, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

Just FYI. I would not waste your time reviewing it. It just moves the common ...

11 years, 12 months ago (2012-05-24 23:53:47 UTC) #1

Very nice! LGTM.

Expand All Messages | Collapse All Messages