Issue 6256063: addPoly() entry-point, to quickly add MoveTo+N*LineTo (useful in dashing)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256063: addPoly() entry-point, to quickly add MoveTo+N*LineTo (useful in dashing) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by reed1

Modified:
12 years, 6 months ago

Reviewers:
bungeman, caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

addPoly() entry-point, to quickly add MoveTo+N*LineTo (useful in dashing) Committed: https://code.google.com/p/skia/source/detail?r=4061

Patch Set 4 : #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -1 line)			Patch
M	include/core/SkPath.h	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 2 3	2 chunks	+38 lines, -0 lines	0 comments	Download
M	tests/PathTest.cpp	View	1 2 3	2 chunks	+67 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

caryclark1

lgtm (curious about questions, though) https://codereview.appspot.com/6256063/diff/2001/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.appspot.com/6256063/diff/2001/src/core/SkPath.cpp#newcode644 src/core/SkPath.cpp:644: } if you used ...

12 years, 6 months ago (2012-05-29 15:23:26 UTC) #3

addressed comments, and added unittest

Expand All Messages | Collapse All Messages