Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5603)

Issue 6256052: Add svndiff tool: runs skdiff over all pending changes in SVN checkout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by epoger
Modified:
12 years, 6 months ago
Reviewers:
bungeman, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add svndiff tool: runs skdiff over all pending changes in SVN checkout This is needed for https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests , and will be generally useful beyond that too. Committed: https://code.google.com/p/skia/source/detail?r=4052

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -0 lines) Patch
M tools/svn.py View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
A tools/svndiff.py View 1 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 5
epoger
first LG wins
12 years, 6 months ago (2012-05-25 17:21:18 UTC) #1
bungeman
https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py#newcode98 tools/svndiff.py:98: original_file_path = os.path.join( This magic will not work with ...
12 years, 6 months ago (2012-05-25 18:00:18 UTC) #2
epoger
https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py#newcode98 tools/svndiff.py:98: original_file_path = os.path.join( On 2012/05/25 18:00:18, bungeman wrote: > ...
12 years, 6 months ago (2012-05-25 19:26:28 UTC) #3
epoger
On 2012/05/25 19:26:28, epoger wrote: > https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py > File tools/svndiff.py (right): > > https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py#newcode98 > ...
12 years, 6 months ago (2012-05-25 19:29:43 UTC) #4
bungeman
12 years, 6 months ago (2012-05-25 19:41:39 UTC) #5
LGTM

On 2012/05/25 19:26:28, epoger wrote:
> https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py
> File tools/svndiff.py (right):
> 
> https://codereview.appspot.com/6256052/diff/1/tools/svndiff.py#newcode98
> tools/svndiff.py:98: original_file_path = os.path.join(
> On 2012/05/25 18:00:18, bungeman wrote:
> > This magic will not work with svn past 1.7 as it uses a database at the top
> > level.
> > 
> > Perhaps something like pulling in the output of
> > 
> > svn cat -r BASE
> > 
> > would work? This isn't supposed to hit the server, see
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1361 .
> 
> Excellent point, thanks!  It turns out that "svn export -R BASE destpath"
works.
>  See change here and in svn.py.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b